mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 64093: Added operators for offer operation update protobuf classes.
Date Thu, 30 Nov 2017 23:23:36 GMT


> On Nov. 30, 2017, 1:40 p.m., Greg Mann wrote:
> > src/messages/messages.hpp
> > Lines 48-50 (patched)
> > <https://reviews.apache.org/r/64093/diff/2/?file=1902023#file1902023line48>
> >
> >     `OfferOperationStatus` is defined in 'include/mesos/mesos.proto', so the correct
place for its operators is 'include/mesos/type_utils.hpp'.
> >     
> >     Note that we also need operators for the V1 version - looks like these go in
'include/mesos/v1/mesos.hpp'.

I moved the v0 operators to `include/mesos/type_utils.hpp`.

There's nothing using the v1 operators, so I would only add them when they're necessary.


- Gaston


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64093/#review192352
-----------------------------------------------------------


On Nov. 30, 2017, 3:22 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64093/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2017, 3:22 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8197
>     https://issues.apache.org/jira/browse/MESOS-8197
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added operators for offer operation update protobuf classes.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp a348c7df083324602d25f40069ad49e29f7918a5 
>   src/common/type_utils.cpp 3657d55ab2a052b5c659022e3fc264e748429d54 
>   src/messages/messages.hpp 2756ebae5e2dccce63030eb7cec55d35445fa97b 
>   src/messages/messages.cpp 6029502e8394817a0ab6ee2f63895ad02349bb0d 
> 
> 
> Diff: https://reviews.apache.org/r/64093/diff/3/
> 
> 
> Testing
> -------
> 
> Added new tests at the end of the chain. They passed 5000 times on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message