mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64143: Added ACKNOWLEDGE event to the resource provider API.
Date Thu, 30 Nov 2017 22:52:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64143/#review192389
-----------------------------------------------------------




include/mesos/resource_provider/resource_provider.proto
Line 37 (original), 37 (patched)
<https://reviews.apache.org/r/64143/#comment270497>

    please update v1 proto too.



include/mesos/resource_provider/resource_provider.proto
Lines 38 (patched)
<https://reviews.apache.org/r/64143/#comment270496>

    See my comment in the following patch. Let's make the code consistent on naming.


- Jie Yu


On Nov. 29, 2017, 5:50 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64143/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 5:50 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Jie Yu.
> 
> 
> Bugs: MESOS-8186
>     https://issues.apache.org/jira/browse/MESOS-8186
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new event is used to send offer operation status udpate
> acknowledgements to resource providers.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resource_provider/resource_provider.proto 615a2ab8a00f4da3906ad0ae322a885c84b3574b

>   src/resource_provider/storage/provider.cpp 49c042cdb1837860aaedde2e48f318ed5ac8b1d1

> 
> 
> Diff: https://reviews.apache.org/r/64143/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message