mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 64093: Added operators for offer operation update protobuf classes.
Date Thu, 30 Nov 2017 21:40:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64093/#review192352
-----------------------------------------------------------




src/messages/messages.hpp
Lines 48-50 (patched)
<https://reviews.apache.org/r/64093/#comment270453>

    `OfferOperationStatus` is defined in 'include/mesos/mesos.proto', so the correct place
for its operators is 'include/mesos/type_utils.hpp'.
    
    Note that we also need operators for the V1 version - looks like these go in 'include/mesos/v1/mesos.hpp'.



src/messages/messages.cpp
Lines 181 (patched)
<https://reviews.apache.org/r/64093/#comment270471>

    Let's say "Status UUID" here to avoid confusion with the operation UUID.



src/messages/messages.cpp
Lines 186-191 (patched)
<https://reviews.apache.org/r/64093/#comment270474>

    Let's try to disambiguate the two operation IDs here. Perhaps something like:
    
    " for operation UUID <operation_uuid> (framework-supplied operation ID '<operation_id>')"



src/messages/messages.cpp
Lines 198 (patched)
<https://reviews.apache.org/r/64093/#comment270475>

    s/in/on/


- Greg Mann


On Nov. 27, 2017, 7:45 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64093/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2017, 7:45 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8197
>     https://issues.apache.org/jira/browse/MESOS-8197
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added operators for offer operation update protobuf classes.
> 
> 
> Diffs
> -----
> 
>   src/messages/messages.hpp 2756ebae5e2dccce63030eb7cec55d35445fa97b 
>   src/messages/messages.cpp 6029502e8394817a0ab6ee2f63895ad02349bb0d 
> 
> 
> Diff: https://reviews.apache.org/r/64093/diff/2/
> 
> 
> Testing
> -------
> 
> Added new tests at the end of the chain. They passed 5000 times on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message