mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64142: Updated master ACCEPT handler to disallow offer operation feedback.
Date Thu, 30 Nov 2017 20:24:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64142/#review192355
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Lines 4139-4143 (patched)
<https://reviews.apache.org/r/64142/#comment270456>

    Can you move this inside the `else if` block below?


- Jie Yu


On Nov. 29, 2017, 5:42 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64142/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 5:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8054
>     https://issues.apache.org/jira/browse/MESOS-8054
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the master's ACCEPT call code path to fail
> offer operations when their `id` field is set. Since protobufs
> have already been updated for offer operation feedback, but the
> feature is not fully implemented, we will disallow the setting
> of this field for now.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 
> 
> 
> Diff: https://reviews.apache.org/r/64142/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message