mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 64218: Terminated the Slave first before cleaning up its dependencies.
Date Thu, 30 Nov 2017 20:05:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64218/#review192353
-----------------------------------------------------------


Ship it!




It should be fine to flip the ordering here.  Since most of the Agent's dependencies are injected,
these dependencies will outlive the Agent's destruction.  And there shouldn't be anything
critical the Agent needs to do upon cleaning up the containerizer (such as mark sandboxes
for GC and such).

- Joseph Wu


On Nov. 30, 2017, 11:13 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64218/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2017, 11:13 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is to ensure that Slave's dependencies do not see any incoming
> requests to avoid potential race conditions. Typically, an object's
> dependencies should be cleaned up after the object is cleaned up
> (reverse of the creation order).
> 
> 
> Diffs
> -----
> 
>   src/tests/cluster.cpp 4ff9faf4e5cae5bca4f050d6f2bc2c60d7ee4e6f 
> 
> 
> Diff: https://reviews.apache.org/r/64218/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message