mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 59294: Optionally scale egress bandwidth with CPU.
Date Thu, 30 Nov 2017 19:12:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59294/#review192333
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/network/port_mapping.cpp
Lines 654-657 (patched)
<https://reviews.apache.org/r/59294/#comment270428>

    This will create a qdisc with the default class ID configured to 0 (default). But our
rate limiting class is 1:1, so it won't get any traffic.
    
    We need to expose HTB qdisc config in the API and set default class ID to 1 here as I
did internally. Or I can copy my internal patches here if you want.



src/slave/containerizer/mesos/isolators/network/port_mapping.cpp
Lines 1875-1876 (patched)
<https://reviews.apache.org/r/59294/#comment270426>

    Wrong limit is logged. Should be `flags.minimum_egress_rate_limit`.


- Ilya Pronin


On July 24, 2017, 11:36 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59294/
> -----------------------------------------------------------
> 
> (Updated July 24, 2017, 11:36 a.m.)
> 
> 
> Review request for mesos, Dmitry Zhuk, Ilya Pronin, Jie Yu, and Reza Motamedi.
> 
> 
> Bugs: MESOS-7508
>     https://issues.apache.org/jira/browse/MESOS-7508
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add support to isolators/port_mapping for optionally scaling egress bandwidth with CPU
and with minimum and maximum limits.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e2502acc3542d64c2b2b13f8c0363a3c8372e20e 
>   src/slave/containerizer/mesos/isolators/network/helper.cpp 4ed879dca42f85fc9dd7638e763822cf10fa8405

>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 9d38289c7161d5e931053b587d115684ccc44c94

>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cd008aaebcd42554a9a81d2b059269546f59c966

>   src/slave/flags.hpp e75c1b4227b443aedf445921b3f2108d930c112c 
>   src/slave/flags.cpp c84aa6724170bba46b4444be8410b71d42a1626e 
>   src/tests/containerizer/port_mapping_tests.cpp 16e015a8ac53a4aa5336b60c40228720b5f6910a

> 
> 
> Diff: https://reviews.apache.org/r/59294/diff/6/
> 
> 
> Testing
> -------
> 
> # added a new test 
> $ make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message