mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 63628: Implemented index_sequence and related functionality.
Date Thu, 30 Nov 2017 17:57:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63628/#review192316
-----------------------------------------------------------



I'm thinking we can actually move this to a `stout/cpp14.hpp` file.
The general thought is that `stout/cpp*.hpp` files can be special places
where we can deviate from stout naming scheme, for example since they are
implementations of future STL components.

This would reduce the confusion as to why a stout utility may not follow
stout conventions, and it would also make the language upgrades simpler
in the future for us since we can simply remove the entire file for
a language upgrade, rather than finding/removing these components that
are spread out in their STL-corresponding-ish files.

- Michael Park


On Nov. 22, 2017, 6:07 a.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63628/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2017, 6:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Bugs: MESOS-6972
>     https://issues.apache.org/jira/browse/MESOS-6972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds implementation of C++14 STL's `index_squence`
> and `make_index_sequence` templates.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/utils.hpp 82cab830817842c23056235973ec4419ee9ec8b1 
> 
> 
> Diff: https://reviews.apache.org/r/63628/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message