mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 63842: Allowed removing non-terminal offer operations.
Date Thu, 30 Nov 2017 16:00:52 GMT


> On Nov. 30, 2017, 1:33 a.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Line 7044 (original)
> > <https://reviews.apache.org/r/63842/diff/8/?file=1903708#file1903708line7044>
> >
> >     Can you add a TODO here to update `Framework::allocatedResources()` to include
those used by non speculative operations?
> >     
> >     This currently only affects endpoints. We should create a ticket to track and
address that.

I created a ticket, https://issues.apache.org/jira/browse/MESOS-8282. Let's track this ticket
instead of adding a `TODO` here where it does not really fit anyway.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63842/#review192204
-----------------------------------------------------------


On Nov. 30, 2017, 5 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63842/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2017, 5 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> During reconcilation we might be required to remove non-terminal offer
> operations from bookkeeping.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 0f8a2ac72c3484f911853c2994fc71a488d66d96 
>   src/master/master.cpp fadc78b2ca5d46b8cc12a794b428753aa79ac095 
>   src/slave/slave.cpp 554a2da6b8e8d0ca8efa0752388f82e48021abce 
> 
> 
> Diff: https://reviews.apache.org/r/63842/diff/9/
> 
> 
> Testing
> -------
> 
> `make check`, tested as part of https://reviews.apache.org/r/63843/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message