mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64086: Removed currently unneeded 'AWAIT_READY's in 'MockResourceProvider'.
Date Thu, 30 Nov 2017 16:00:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64086/
-----------------------------------------------------------

(Updated Nov. 30, 2017, 5 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
-------

Rebased.


Repository: mesos


Description
-------

The 'AWAIT_READY's in 'MockResourceProvider' let to the resource
provider not being usable with paused clock as we would run into a
deadclock in that case.

This patch removes the explicit awaits here to make this resource
provider usable. We should consider making it easier to debug send
failures in the resource provider, e.g., by surfacing the future
responses to users in some way, or by added additional logging.


Diffs (updated)
-----

  src/tests/mesos.hpp 5fe53564237f3647f0e8e247acb3da8572a91f52 


Diff: https://reviews.apache.org/r/64086/diff/4/

Changes: https://reviews.apache.org/r/64086/diff/3-4/


Testing
-------

`make check`, tests as part of https://reviews.apache.org/r/63843/.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message