mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 64168: Introduced a 'OperationUUID' type.
Date Thu, 30 Nov 2017 14:37:43 GMT


> On Nov. 30, 2017, 4:05 a.m., Jie Yu wrote:
> > include/mesos/mesos.proto
> > Lines 2186 (patched)
> > <https://reviews.apache.org/r/64168/diff/1/?file=1903735#file1903735line2186>
> >
> >     In fact, I think it might make sense to make it a general UUID type (rather
than specific to `Operation`).
> >     
> >     I remembered there's a TODO somewhere in mesos.proto about that.
> >     
> >     I don't know if we can use the same name `UUID`. One way is to use `Uuid`, or
`UUIDInfo`. Or we just use `mesos::UUID` through out.

Yes, naming it `UUID` would lead to a lot of namespace resolution issues with the stout's
`UUID`, even if we'd use `mesos::UUID`. We'd have to change every use of that to `::UUID`
as we're always in `mesos` namespace.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64168/#review192230
-----------------------------------------------------------


On Nov. 29, 2017, 6:07 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64168/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 6:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8c28b81def82e6af80fb1920f8a39d4406ee797c 
>   include/mesos/resource_provider/resource_provider.proto 615a2ab8a00f4da3906ad0ae322a885c84b3574b

>   include/mesos/type_utils.hpp f7f23270fadc75a8737f32ec1c3fbc01f6321248 
>   include/mesos/v1/mesos.proto 35bc6e1cdef9a2da268a72f8f19baf2ea708353c 
>   include/mesos/v1/resource_provider/resource_provider.proto 7197b9ba3f761d618e5d67662a5f3fba72701ef0

>   src/common/protobuf_utils.cpp c0ff306ae6c16cbba6fd08469b639b9f906c672b 
>   src/common/type_utils.cpp 14267559f228f23aff2e21b987795b9f4fee93fc 
>   src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d 
>   src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 
>   src/messages/messages.proto d7ef68f85a9f8a7702a83a3554c2dedc6d7ee339 
>   src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00 
>   src/resource_provider/message.hpp c94e9c7f0bb512cc579b5fe569831002a32256b0 
>   src/slave/slave.cpp e1566832f90cca372ad2f1cc13d1e7f76fa53285 
>   src/tests/mesos.hpp 68f78d01d2145532f6873e824fdb6e16a278daad 
>   src/tests/resource_provider_manager_tests.cpp 0b7c4ad6bb0052847b884959e3171cd7ab382b45

>   src/tests/resource_provider_validation_tests.cpp bf789a05771b7c25f2fc2a8a5b35d38519e4793b

> 
> 
> Diff: https://reviews.apache.org/r/64168/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message