mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64151: Added an agent endpoint to list resource providers.
Date Thu, 30 Nov 2017 03:07:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/#review192232
-----------------------------------------------------------




src/slave/slave.cpp
Lines 804 (patched)
<https://reviews.apache.org/r/64151/#comment270262>

    Hum, i think we stop adding v0 operator APIs. We should instead add a v1 operator API
`GET_RESOURCE_PROVIDERS`


- Jie Yu


On Nov. 29, 2017, 11:23 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64151/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 11:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8270
>     https://issues.apache.org/jira/browse/MESOS-8270
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The 'resource_providers' endpoint will list all subscribed local
> resource providers of an agent. It shows all informations that
> are part of a 'ResourceProviderInfo'.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/index.md 871153774c4b21cdca4afec9bc2ce2bd955b17c4 
>   docs/endpoints/slave/resource_providers.md PRE-CREATION 
>   src/resource_provider/manager.hpp e7a9a6cc6b15372d8f3f11e17fa2297792b00ff9 
>   src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00 
>   src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3 
>   src/slave/http.cpp 394e91013dc11e0a79e2e00534864281cc74ad2f 
>   src/slave/slave.cpp e1566832f90cca372ad2f1cc13d1e7f76fa53285 
>   src/tests/resource_provider_manager_tests.cpp 0b7c4ad6bb0052847b884959e3171cd7ab382b45

> 
> 
> Diff: https://reviews.apache.org/r/64151/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message