mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64086: Removed currently unneeded 'AWAIT_READY's in 'MockResourceProvider'.
Date Thu, 30 Nov 2017 01:55:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64086/#review192221
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Nov. 29, 2017, 4:27 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64086/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 4:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The 'AWAIT_READY's in 'MockResourceProvider' let to the resource
> provider not being usable with paused clock as we would run into a
> deadclock in that case.
> 
> This patch removes the explicit awaits here to make this resource
> provider usable. We should consider making it easier to debug send
> failures in the resource provider, e.g., by surfacing the future
> responses to users in some way, or by added additional logging.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 68f78d01d2145532f6873e824fdb6e16a278daad 
> 
> 
> Diff: https://reviews.apache.org/r/64086/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`, tests as part of https://reviews.apache.org/r/63843/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message