mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 64187: Included `stout/os/realpath.hpp` in `flags.hpp`.
Date Thu, 30 Nov 2017 01:51:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64187/#review192218
-----------------------------------------------------------


Ship it!




Ship It!

- Akash Gupta


On Nov. 30, 2017, 1:18 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64187/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2017, 1:18 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This was used but not included, and broke on Windows because no other
> headers included it.
> 
> 
> Diffs
> -----
> 
>   src/tests/flags.hpp 0050fc99198d29a2e4597fa2a3c138ac29b9c379 
> 
> 
> Diff: https://reviews.apache.org/r/64187/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on CentOS 7
> 
> All tests passed on Windows 10 (with exception of known failing test `HealthCheckTest.HealthyTaskViaTCP`).
`stout-tests` passed under `--gtest_repeat=100`.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message