mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 64182: Windows: Cleaned up `os::exists`.
Date Thu, 30 Nov 2017 01:51:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64182/#review192217
-----------------------------------------------------------


Ship it!




Ship It!

- Akash Gupta


On Nov. 29, 2017, 10:45 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64182/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 10:45 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> More const, RAII, and comments.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/exists.hpp 7c8c85ccef723d138a3555a84f6bd9d8e45e601a

> 
> 
> Diff: https://reviews.apache.org/r/64182/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message