mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 64188: Fixed Windows `HealthCheckTest.HealthyTaskViaTCP` test failure.
Date Thu, 30 Nov 2017 00:48:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64188/#review192206
-----------------------------------------------------------


Ship it!




Ship It!

- Gaston Kleiman


On Nov. 29, 2017, 4:41 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64188/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 4:41 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `int socket = ::socket()` was used instead of `int_fd socket = ...`,
> causing Windows to use the wrong `WindowsFD` constructor, throwing
> an assertion failure.
> 
> 
> Diffs
> -----
> 
>   src/checks/tcp_connect.cpp 17d7abf924557568137dded9d1f0729213b8e4a9 
> 
> 
> Diff: https://reviews.apache.org/r/64188/diff/1/
> 
> 
> Testing
> -------
> 
> Ran HealthCheckTest.HealthyTaskViaTCP on Windows + Linux.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message