mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63842: Allowed removing non-terminal offer operations.
Date Thu, 30 Nov 2017 00:33:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63842/#review192204
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Lines 10953 (patched)
<https://reviews.apache.org/r/63842/#comment270244>

    kill this line?



src/slave/slave.cpp
Line 7044 (original)
<https://reviews.apache.org/r/63842/#comment270245>

    Can you add a TODO here to update `Framework::allocatedResources()` to include those used
by non speculative operations?
    
    This currently only affects endpoints. We should create a ticket to track and address
that.


- Jie Yu


On Nov. 29, 2017, 4:27 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63842/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 4:27 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> During reconcilation we might be required to remove non-terminal offer
> operations from bookkeeping.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d 
>   src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 
>   src/slave/slave.cpp e1566832f90cca372ad2f1cc13d1e7f76fa53285 
> 
> 
> Diff: https://reviews.apache.org/r/63842/diff/8/
> 
> 
> Testing
> -------
> 
> `make check`, tested as part of https://reviews.apache.org/r/63843/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message