mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64177: Added a test in ContainerDaemon for testing failed authorization.
Date Wed, 29 Nov 2017 23:47:59 GMT


> On Nov. 29, 2017, 11:39 p.m., Chun-Hung Hsiao wrote:
> > src/tests/container_daemon_tests.cpp
> > Lines 244 (patched)
> > <https://reviews.apache.org/r/64177/diff/1/?file=1904041#file1904041line244>
> >
> >     Isn't it true that the secret generator will always be nonnull?

If SSL is not enabled, it'll be null.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64177/#review192189
-----------------------------------------------------------


On Nov. 29, 2017, 10:03 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64177/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 10:03 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test in ContainerDaemon for testing failed authorization.
> 
> 
> Diffs
> -----
> 
>   src/tests/container_daemon_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64177/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message