mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <>
Subject Re: Review Request 64183: Fixed Windows (and maybe clang) build break.
Date Wed, 29 Nov 2017 23:15:25 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 29, 2017, 11:15 p.m.)

Review request for mesos and Andrew Schwartzmeyer.

Bugs: MESOS-8277

Repository: mesos


Commit 17d186e379d2db3edb04743a061dc05e24c32c9b introduced a
0 size array in `mesos::internal::master::MASTER_CAPABILITIES()`. This
is not valid C++, but instead a GCC C++ extension, so it broke the
Windows build. Since `MASTER_CAPABILITIES()` just returns an empty
vector for now, the code now just simply returns `{}`.


  src/master/constants.cpp bf3d3e449d2df7c2ff18dc8891500b03da98d096 



Compiled on Windows. Currently compiling on Linux.


Akash Gupta

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message