mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 64183: Fixed Windows (and maybe clang) build break.
Date Wed, 29 Nov 2017 23:14:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64183/
-----------------------------------------------------------

Review request for mesos and Andrew Schwartzmeyer.


Repository: mesos


Description
-------

Commit 17d186e379d2db3edb04743a061dc05e24c32c9b introduced a
0 size array in `mesos::internal::master::MASTER_CAPABILITIES()`. This
is not valid C++, but instead a GCC C++ extension, so it broke the
Windows build. Since `MASTER_CAPABILITIES()` just returns an empty
vector for now, the code now just simply returns `{}`.


Diffs
-----

  src/master/constants.cpp bf3d3e449d2df7c2ff18dc8891500b03da98d096 


Diff: https://reviews.apache.org/r/64183/diff/1/


Testing
-------

Compiled on Windows. Currently compiling on Linux.


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message