mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63817: Windows: Enabled more agent tests.
Date Wed, 29 Nov 2017 22:49:20 GMT


> On Nov. 27, 2017, 6:18 p.m., Akash Gupta wrote:
> > src/tests/slave_tests.cpp
> > Lines 339 (patched)
> > <https://reviews.apache.org/r/63817/diff/1/?file=1892195#file1892195line339>
> >
> >     Should the #ifdef be inside a function / variable instead of copy + pasting
into multiple tests?

Yeahhh probably. Thanks.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63817/#review191989
-----------------------------------------------------------


On Nov. 29, 2017, 2:49 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63817/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 2:49 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-6714
>     https://issues.apache.org/jira/browse/MESOS-6714
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These tests "just worked" once the isolators and command was fixed to be
> Windows-compatible. Particularly, `/bin/echo --author` was replaced with
> an equivalent PowerShell command, and `posix/cpu,posix/mem` was replaced
> with `windows/cpu`.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp b35497bfa9363815845f339b6c3a7f871932b26d 
> 
> 
> Diff: https://reviews.apache.org/r/63817/diff/3/
> 
> 
> Testing
> -------
> 
> This is the preliminary work I was doing to start fixing the agent recovery path on Windows.
However, since we don't do _any_ checkpointing currently, that bug is much more involved,
and I wanted to get these patches up sooner rather than later as they enable a dozen more
agent tests.
> 
> This is dependent on the isolator chain because of the cleanup work done in `stout/windows/os.hpp`
etc. that this code also touched.
> 
> Test results in non-administrative prompt:
> 
> # mesos-tests
> 
> ```
> [----------] Global test environment tear-down
> [==========] 755 tests from 78 test cases ran. (156570 ms total)
> [  PASSED  ] 755 tests.
> 
>   YOU HAVE 182 DISABLED TESTS
> ```
> 
> In comparison to `master`:
> 
> ```
> [----------] Global test environment tear-down
> [==========] 747 tests from 76 test cases ran. (337529 ms total)
> [  PASSED  ] 747 tests.
> 
>   YOU HAVE 187 DISABLED TESTS
> ```
> 
> # libprocess-tests
> 
> ```
> [----------] Global test environment tear-down
> [==========] 158 tests from 29 test cases ran. (992 ms total)
> [  PASSED  ] 158 tests.
> ```
> 
> # stout-tests
> 
> ```
> [----------] Global test environment tear-down
> [==========] 259 tests from 43 test cases ran. (5185 ms total)
> [  PASSED  ] 259 tests.
> ```
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message