mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63815: Windows: Fixed environment priorities in `shell.hpp`.
Date Wed, 29 Nov 2017 22:48:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63815/
-----------------------------------------------------------

(Updated Nov. 29, 2017, 2:48 p.m.)


Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and Michael Park.


Changes
-------

Rebased.


Bugs: MESOS-6816
    https://issues.apache.org/jira/browse/MESOS-6816


Repository: mesos


Description
-------

Legacy code had caused the system environment to explicitly override the
supplied environment, but this is incorrect. The system environment
should be the default, with any supplied environment variables
overriding those.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/windows/shell.hpp 5c711837a3adbc89ad8793666e68eff7102566b3



Diff: https://reviews.apache.org/r/63815/diff/2/

Changes: https://reviews.apache.org/r/63815/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message