mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63812: Windows: Fixed `os::realpath` to behave like POSIX version.
Date Wed, 29 Nov 2017 22:48:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63812/
-----------------------------------------------------------

(Updated Nov. 29, 2017, 2:48 p.m.)


Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and Michael Park.


Changes
-------

Rebased.


Bugs: MESOS-6735
    https://issues.apache.org/jira/browse/MESOS-6735


Repository: mesos


Description
-------

The existing implementation (1) did not resolve symlinks and (2) did not
check for existence of the path. This resulted in unexpected behaviors
by users of the function.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/windows/realpath.hpp 81a33bd2708c0871c4f23c12fdd29fc8d35682e3



Diff: https://reviews.apache.org/r/63812/diff/3/

Changes: https://reviews.apache.org/r/63812/diff/2-3/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message