mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63809: Windows: Fixed `fs::symlink` to not need admin privileges.
Date Wed, 29 Nov 2017 22:46:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63809/
-----------------------------------------------------------

(Updated Nov. 29, 2017, 2:46 p.m.)


Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and Michael Park.


Changes
-------

Forgot to remove now unnecessary mutex and comment.


Summary (updated)
-----------------

Windows: Fixed `fs::symlink` to not need admin privileges.


Bugs: MESOS-7370
    https://issues.apache.org/jira/browse/MESOS-7370


Repository: mesos


Description
-------

This new feature of Windows 10 allows us to make symlinks without being
an administrator. In the future, we may want to do a version check, as
this is likely to fail on versions of Windows which don't support this
flag. Resolves MESOS-7370.


Diffs (updated)
-----

  3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp e3d04480cf793482d958ea9571d96a29b6bf09b1



Diff: https://reviews.apache.org/r/63809/diff/2/

Changes: https://reviews.apache.org/r/63809/diff/1-2/


Testing
-------

Ran `mesos-tests` not in an admin prompt!


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message