mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 64012: Added new --reconfiguration_compatibility slave flag and implementation.
Date Wed, 29 Nov 2017 19:10:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64012/
-----------------------------------------------------------

(Updated Nov. 29, 2017, 7:10 p.m.)


Review request for mesos and Vinod Kone.


Summary (updated)
-----------------

Added new --reconfiguration_compatibility slave flag and implementation.


Repository: mesos


Description (updated)
-------

This flag allows operators to weaken the checks performed by the agent
when recovering state, in particular it allows to recover running tasks
even when parts of the recovered SlaveInfo don't match the current
state.

The set of possible changes is quite restricted for now,
to avoid accidenetally introducing semantic bugs.


Diffs (updated)
-----

  src/CMakeLists.txt be212d9316e1b8a605b2f7f2cdaae37a3b0871bf 
  src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8 
  src/slave/compatibility.hpp PRE-CREATION 
  src/slave/compatibility.cpp PRE-CREATION 
  src/slave/flags.hpp f25d8aff29d0698eaf06dd40a86a35e43bc9e094 
  src/slave/flags.cpp 7998d9bb66995ad0d1285fcb1042321afdf917a9 
  src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059 
  src/slave/slave.cpp e1566832f90cca372ad2f1cc13d1e7f76fa53285 
  src/tests/CMakeLists.txt 8997cc0f762aa27decaa24a147a8581549a82e80 
  src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9 
  src/tests/master_tests.cpp 01f45a9bb6378c5fded31bf58fbcad93fe7ed719 
  src/tests/slave_compatibility_tests.cpp PRE-CREATION 
  src/tests/slave_tests.cpp aeaa923f36af134b61ad9df93c95651a8d9bc23c 


Diff: https://reviews.apache.org/r/64012/diff/4/

Changes: https://reviews.apache.org/r/64012/diff/3-4/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message