mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.
Date Wed, 29 Nov 2017 19:09:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review192151
-----------------------------------------------------------




src/master/master.cpp
Lines 6913 (patched)
<https://reviews.apache.org/r/64011/#comment270172>

    s/because/ because/



src/master/master.cpp
Line 6872 (original), 6923 (patched)
<https://reviews.apache.org/r/64011/#comment270173>

    s/command/update/



src/master/master.cpp
Line 6873 (original), 6924 (patched)
<https://reviews.apache.org/r/64011/#comment270175>

    s/reset/remove/



src/master/master.cpp
Lines 6928 (patched)
<https://reviews.apache.org/r/64011/#comment270176>

    This might need to be removed after the change to upgrade slaveinfo at the very beginning
of registration process.



src/master/master.cpp
Line 11174 (original), 11183 (patched)
<https://reviews.apache.org/r/64011/#comment270180>

    Make a NOTE that there is a window of time between re-registration and updateslave message
where the total could be incorrect.
    
    Instead of basing this on `info` getting updated, put this in a separate if statement
that checks if `total` got updated.


- Vinod Kone


On Nov. 29, 2017, 6:27 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 6:27 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d 
>   src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 
> 
> 
> Diff: https://reviews.apache.org/r/64011/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message