mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64170: Fall back to binding devices if mknod fails.
Date Wed, 29 Nov 2017 18:48:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64170/#review192156
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Nov. 29, 2017, 6:40 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64170/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 6:40 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-8272
>     https://issues.apache.org/jira/browse/MESOS-8272
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When importing device nodes into a chroot, the `mknod` can fail
> due to devices cgroup or user namespace restrictions. In this
> case, we can fall back to bind mounting device nodes into the
> new chroot.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp c69e7c2e00cd129d3ddbb70517852d280a7f593a 
> 
> 
> Diff: https://reviews.apache.org/r/64170/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message