mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.
Date Wed, 29 Nov 2017 18:29:43 GMT


> On Nov. 23, 2017, 12:52 a.m., Vinod Kone wrote:
> > src/master/master.cpp
> > Line 6672 (original), 6609 (patched)
> > <https://reviews.apache.org/r/64011/diff/1/?file=1900319#file1900319line6699>
> >
> >     Reject if agent is being marked gone or already marked gone. Can you do this
and the previous similar change in a separate review?

https://reviews.apache.org/r/64169/


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review191767
-----------------------------------------------------------


On Nov. 29, 2017, 6:27 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 6:27 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d 
>   src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 
> 
> 
> Diff: https://reviews.apache.org/r/64011/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message