mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().
Date Wed, 29 Nov 2017 18:17:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64010/
-----------------------------------------------------------

(Updated Nov. 29, 2017, 6:17 p.m.)


Review request for mesos and Vinod Kone.


Summary (updated)
-----------------

Added additional parameters to Allocator::updateSlave().


Repository: mesos


Description (updated)
-------

The current `SlaveInfo` of a slave is now passed as an additional
parameter to `updateSlave()`, to account for the possibility of
it changing during an agent restart.

While the existing HierarchicalDRFAllocator only cares about the domain
and hostname fields, the full SlaveInfo is passed since custom
allocators might base their scheduling decisions on other fields, for
example attributes.

Additionally, this also provides callers with an option to reset
existing offer filters for a given slave id when the update is
applied.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp ae122003487ca8956573e993cd3993aa8cc286f1 
  src/master/allocator/mesos/allocator.hpp 8fa4fdeec4ec64bcd49fc442c230d8684a11cfd9 
  src/master/allocator/mesos/hierarchical.hpp 2c4832b29842330fa57756cd3d4202f265a820f3 
  src/master/allocator/mesos/hierarchical.cpp 5ce9ceaa3a5f84a1e076d45448863c418531cc2b 
  src/tests/allocator.hpp 6a84f1beb86dceb5a5e9bf4615c13a216f3d0905 
  src/tests/hierarchical_allocator_tests.cpp f0f95ba4f667bf8ea54e985d8cde913a4170d8ff 


Diff: https://reviews.apache.org/r/64010/diff/4/

Changes: https://reviews.apache.org/r/64010/diff/3-4/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message