mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 64006: Moved registry operations into separate header.
Date Wed, 29 Nov 2017 18:04:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64006/
-----------------------------------------------------------

(Updated Nov. 29, 2017, 6:04 p.m.)


Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

The definition of the various master registry operations is only
needed when trying to access registry, so they were moved into a
separate file in order to decrease size and complexity of the
master.hpp header.


Diffs (updated)
-----

  src/CMakeLists.txt be212d9316e1b8a605b2f7f2cdaae37a3b0871bf 
  src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8 
  src/master/http.cpp 10084125deb839a9846a4f64d2e433ff02754c02 
  src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d 
  src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 
  src/master/registry_operations.hpp PRE-CREATION 
  src/master/registry_operations.cpp PRE-CREATION 
  src/tests/master_tests.cpp 01f45a9bb6378c5fded31bf58fbcad93fe7ed719 
  src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7 
  src/tests/persistent_volume_tests.cpp 56b55210ce75907bad9ca50246991c14990e0dca 
  src/tests/reconciliation_tests.cpp 18551ba9955cdd3e94327710813b91cf49c97fa0 
  src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872 
  src/tests/slave_tests.cpp aeaa923f36af134b61ad9df93c95651a8d9bc23c 


Diff: https://reviews.apache.org/r/64006/diff/5/

Changes: https://reviews.apache.org/r/64006/diff/4-5/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message