mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 64142: Updated master ACCEPT handler to disallow offer operation feedback.
Date Wed, 29 Nov 2017 17:42:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64142/
-----------------------------------------------------------

(Updated Nov. 29, 2017, 5:42 p.m.)


Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.


Repository: mesos


Description
-------

This patch updates the master's ACCEPT call code path to fail
offer operations when their `id` field is set. Since protobufs
have already been updated for offer operation feedback, but the
feature is not fully implemented, we will disallow the setting
of this field for now.


Diffs
-----

  src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 


Diff: https://reviews.apache.org/r/64142/diff/1/


Testing
-------

make check


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message