mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 64009: Added new UpdateSlave registry operation.
Date Wed, 29 Nov 2017 16:30:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64009/#review192128
-----------------------------------------------------------



I think the fact that `UpdateSlave` gets a `SlaveInfo` in the old format is due
to the fact that we don't upgrade those resources in the master until we get to
the `Slave` struct ctors, as well as the fact that the agents *always* send
messages in the old format today (due to lack of master capabilities). Once we
update the code such that new agents send messages in the new format, we'll
need to add code to *downgrade* for the registrar.

Given this, it would be awesome if we upgrade the resources earlier in
the master and downgrade for the registrar correspondingly now. This means that
we only need to upgrade the `SlaveInfo` coming out of the registry to perform
the comparison, rather than introducing a `equalAfterConversion` function which
feels off to me.

Having said all of that, I don't know the urgency nor the scope of the work
being done here. The current solution works for now, so if you want and/or need
to proceed with this, I won't stop it.

- Michael Park


On Nov. 27, 2017, 3:56 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64009/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2017, 3:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This operation can be used to update the stored state
> of an existing, admitted slave.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp b2aa3654db2fe7d7d9d275ded81c6d54244654ee 
>   src/common/protobuf_utils.cpp 34054846f93f19ba550afe58e2a899d111ad38dc 
>   src/master/registry_operations.hpp PRE-CREATION 
>   src/master/registry_operations.cpp PRE-CREATION 
>   src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872 
> 
> 
> Diff: https://reviews.apache.org/r/64009/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message