mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 63731: Reconciled pending resource provider operations in agent.
Date Wed, 29 Nov 2017 16:28:14 GMT


> On Nov. 29, 2017, 4:13 a.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Lines 6900 (patched)
> > <https://reviews.apache.org/r/63731/diff/6/?file=1902744#file1902744line6905>
> >
> >     See my comments in https://reviews.apache.org/r/63843/
> >     
> >     What if both the RP and the agent knows about the operation, and RP sends an
update total due to speculation failure?
> >     
> >     This needs more thinking. Any reason not let agent/master knows about the latest
state of the offer operation. Is the intention here to rely on status update manager to send
the status update?
> >     
> >     At the very least, let's document this scenario.
> 
> Jie Yu wrote:
>     Probabaly leverage `OfferOperation.latest_status` (which is the latest known status,
which is different than `OfferOperation.statuses` which is ordered)
> 
> Jie Yu wrote:
>     Also, worth checking what we do for tasks.

For simplicity I would prefer if the status of an operation would only be modified by explicit
status updates, while reconciliation would make sure that tasks which need to be known to
the master are known. It seems we follow a similar approach for tasks.

I added notes explaining this approach to both the agent code here and to the master in https://reviews.apache.org/r/63732/
similarly.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63731/#review192104
-----------------------------------------------------------


On Nov. 29, 2017, 5:27 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63731/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 5:27 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8207
>     https://issues.apache.org/jira/browse/MESOS-8207
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When resource providers update their state they send a list of
> pending or unacknowledged operations to the agent. This patch add
> tracking for such operations to the agent. The agent can then forward
> these operations to the master, e.g., for calculating the unused
> resources behind an agent.
> 
> We track an operation until we either receive a updated list of
> pending or unacknowledged operations from a resource provider, or
> until we see an acknowledgement from a framework. This keeps the list
> of operations bounded and ensures that we maintain the latest
> information in the agent.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp e1566832f90cca372ad2f1cc13d1e7f76fa53285 
> 
> 
> Diff: https://reviews.apache.org/r/63731/diff/7/
> 
> 
> Testing
> -------
> 
> `make check`, tested as part of https://reviews.apache.org/r/63843/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message