mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 63843: Implemented a test of offer operation reconcilation.
Date Wed, 29 Nov 2017 16:28:11 GMT


> On Nov. 29, 2017, 4:09 a.m., Jie Yu wrote:
> > src/tests/slave_tests.cpp
> > Lines 8831-8839 (patched)
> > <https://reviews.apache.org/r/63843/diff/6/?file=1902759#file1902759line8831>
> >
> >     Any reason these EXPECT are in the scope?

I put these here since the framework's subscription triggered them. I agree that they could
be set just as well in the scope of the framework where I moved them now.


> On Nov. 29, 2017, 4:09 a.m., Jie Yu wrote:
> > src/tests/slave_tests.cpp
> > Lines 8933-8936 (patched)
> > <https://reviews.apache.org/r/63843/diff/6/?file=1902759#file1902759line8933>
> >
> >     This is a bit subtle. If a speculative operation fails, the update state will
inform the agent that the operation has failed. However, the agent will inform that master
that the operation is still pending?
> >     
> >     What's the downside of telling agent master the same thing (that the operation
has failed)?
> >     
> >     This probably needs more thinking.

This seems strongly related to https://reviews.apache.org/r/63731/#comment270131. Please see
my comment there.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63843/#review192103
-----------------------------------------------------------


On Nov. 29, 2017, 5:27 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63843/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 5:27 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Whenever a speculated operation fails in a resource provider, we
> expect the agent to trigger a 'UpdateSlaveMessage' to the master so it
> can rollback its agent state. This patch adds such a test.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp aeaa923f36af134b61ad9df93c95651a8d9bc23c 
> 
> 
> Diff: https://reviews.apache.org/r/63843/diff/7/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message