mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 64018: Added tests for the d_type support validation.
Date Tue, 28 Nov 2017 23:19:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64018/#review192074
-----------------------------------------------------------




src/tests/containerizer/xfs_quota_tests.cpp
Lines 53 (patched)
<https://reviews.apache.org/r/64018/#comment270082>

    This whole test is linux-specific so we don't need to guard this.



src/tests/containerizer/xfs_quota_tests.cpp
Line 88 (original), 92 (patched)
<https://reviews.apache.org/r/64018/#comment270083>

    Let's make the signature
    ```
      ROOT_XFS_TestBase(
          const Option<std::string>& _mountOptions = None(),
          const Option<std::string>& _mkfsOptions = None())
    ```
    
    So that we don't have to change all the derived classes.
    
    Formatting should look like (note 2 space indent):
    ```
      ROOT_XFS_TestBase(
          const Option<std::string>& _mountOptions = None(),
          const Option<std::string>& _mkfsOptions = None())
        : mkfsOptions(_mkfsOptions), mountOptions(_mountOptions) {}
    ```



src/tests/containerizer/xfs_quota_tests.cpp
Lines 128 (patched)
<https://reviews.apache.org/r/64018/#comment270084>

    ```
    mkfsOptions.getOrElse("")
    ```



src/tests/containerizer/xfs_quota_tests.cpp
Line 134 (original), 142 (patched)
<https://reviews.apache.org/r/64018/#comment270085>

    ```
    mountOptions.getOrElse("")
    ```



src/tests/containerizer/xfs_quota_tests.cpp
Lines 224 (patched)
<https://reviews.apache.org/r/64018/#comment270086>

    Make these both `Option<string>`.



src/tests/containerizer/xfs_quota_tests.cpp
Lines 1182 (patched)
<https://reviews.apache.org/r/64018/#comment270087>

    Better to make the `mkfs` parameters explicit here.
    ```
      ROOT_XFS_FtypeOnTest()
        : ROOT_XFS_TestBase(None(), "-n ftype=1 -m crc=1") {}
    ```



src/tests/containerizer/xfs_quota_tests.cpp
Lines 1191 (patched)
<https://reviews.apache.org/r/64018/#comment270088>

    Should be formatted like this:
    ```
      ROOT_XFS_FtypeOffTest()
        : ROOT_XFS_TestBase(None(), "-n ftype=0 -m crc=0") {}
    ```



src/tests/containerizer/xfs_quota_tests.cpp
Lines 1207 (patched)
<https://reviews.apache.org/r/64018/#comment270089>

    These tests don't actually need the docker image, they just need to start the agent.



src/tests/containerizer/xfs_quota_tests.cpp
Lines 1252 (patched)
<https://reviews.apache.org/r/64018/#comment270090>

    Too many blank lines.


- James Peach


On Nov. 22, 2017, 1:26 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64018/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2017, 1:26 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for the d_type support validation.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 83fa7f2a7e0d31891834669d7b31f18d2fa08035

> 
> 
> Diff: https://reviews.apache.org/r/64018/diff/1/
> 
> 
> Testing
> -------
> 
> All related tests passed.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message