mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 63815: Windows: Fixed environment priorities in `shell.hpp`.
Date Tue, 28 Nov 2017 02:05:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63815/#review191987
-----------------------------------------------------------


Ship it!




Ship It!

- Akash Gupta


On Nov. 14, 2017, 11:16 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63815/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2017, 11:16 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-6816
>     https://issues.apache.org/jira/browse/MESOS-6816
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Legacy code had caused the system environment to explicitly override the
> supplied environment, but this is incorrect. The system environment
> should be the default, with any supplied environment variables
> overriding those.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 5c711837a3adbc89ad8793666e68eff7102566b3

> 
> 
> Diff: https://reviews.apache.org/r/63815/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message