mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 64074: Added ENABLE_HTTP_SERVER option for cmake.
Date Tue, 28 Nov 2017 01:12:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64074/#review191971
-----------------------------------------------------------


Fix it, then Ship it!




Why just cmake?


cmake/CompilationConfigure.cmake
Lines 100-103 (patched)
<https://reviews.apache.org/r/64074/#comment269935>

    For someone that doesn't know the details, this naming seems a little unintuitive, i.e.
doesn't libprocess already have an http server?
    
    I'm also a little worried about how long it will take us to migrate to the new http server
code. Is there a plan in place for the transition of the default? Why not transition the default
to TRUE to begin with? Is the primary concern the lack of benchmarks? Would be good to document
this for posterity in some of these commits.


- Benjamin Mahler


On Nov. 26, 2017, 10:28 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64074/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2017, 10:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Avinash sridharan, and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added ENABLE_HTTP_SERVER option for cmake.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake deb574200bceb605a60b536a396c98d9247c6018 
> 
> 
> Diff: https://reviews.apache.org/r/64074/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message