mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63385: Added utility functions for volume attributes and printing CSI messages.
Date Tue, 28 Nov 2017 00:57:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63385/
-----------------------------------------------------------

(Updated Nov. 28, 2017, 12:57 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Removed comparison for `GetPluginInfoResponse`, and made a generic output operator for all
messages defined in namespace `::csi`.


Summary (updated)
-----------------

Added utility functions for volume attributes and printing CSI messages.


Repository: mesos


Description (updated)
-------

Added utility functions for volume attributes and printing CSI messages.


Diffs (updated)
-----

  src/common/protobuf_utils.hpp 6f991e86e46512d5a2bc4e67e160189fccb77f6a 
  src/common/protobuf_utils.cpp c0ff306ae6c16cbba6fd08469b639b9f906c672b 
  src/csi/utils.hpp PRE-CREATION 
  src/csi/utils.cpp PRE-CREATION 
  src/tests/protobuf_utils_tests.cpp 2be26a5f467be85ec0ad28dcd8202e603e4a9d5e 


Diff: https://reviews.apache.org/r/63385/diff/4/

Changes: https://reviews.apache.org/r/63385/diff/3-4/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message