mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63060: Added utility functions and structures for CSI version and capabilities.
Date Tue, 28 Nov 2017 00:56:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/
-----------------------------------------------------------

(Updated Nov. 28, 2017, 12:56 a.m.)


Review request for mesos, Benjamin Mahler and Jie Yu.


Changes
-------

Removed the `csi::` prefix. Since the helper functions are moved into the `::csi` namespace,
the prefix is no longer needed.


Repository: mesos


Description
-------

This patch adds some helper structures and functions for CSI protobuf.
The comparison and output operators for `csi::Version` are declared in
the `::csi` namespace so they can find it through ADL. Also, it exposes
`::csi` in `mesos::csi` in `spec.hpp` instead of `client.hpp`.


Diffs (updated)
-----

  src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8 
  src/csi/client.hpp a5571f40eba60a07154a7ef3ebe36c925629ac63 
  src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa 
  src/csi/utils.hpp PRE-CREATION 
  src/csi/utils.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63060/diff/6/

Changes: https://reviews.apache.org/r/63060/diff/5-6/


Testing
-------

make


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message