mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 61157: Refactored ProcessManager::handle for future use with http::Server.
Date Tue, 28 Nov 2017 00:50:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61157/#review191950
-----------------------------------------------------------


Ship it!




Coming back to this change without context, it took some time to realize that this change
was primarily about returning a `Future<Response>` from `ProcessManager::handle`. A
commit description for posterity would be helpful IMO.


3rdparty/libprocess/src/process.cpp
Lines 829-831 (patched)
<https://reviews.apache.org/r/61157/#comment269927>

    Looks like we can std::move in the future as well, but not until dmitry's patches land,
not sure if you want to put down a TODO for this.



3rdparty/libprocess/src/process.cpp
Lines 2641-2642 (original), 2608-2609 (patched)
<https://reviews.apache.org/r/61157/#comment269924>

    Can this be removed?


- Benjamin Mahler


On July 27, 2017, 1:55 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61157/
> -----------------------------------------------------------
> 
> (Updated July 27, 2017, 1:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored ProcessManager::handle for future use with http::Server.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp 571ffb1ea5c4787f10c2f4dee249aadc8b904bc6

>   3rdparty/libprocess/src/process.cpp 64bcce215d19558dd493e30e96ca16577fe0722a 
> 
> 
> Diff: https://reviews.apache.org/r/61157/diff/5/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message