mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@apache.org>
Subject Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.
Date Tue, 28 Nov 2017 00:36:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64011/#review191958
-----------------------------------------------------------




src/master/master.cpp
Lines 6879 (patched)
<https://reviews.apache.org/r/64011/#comment269918>

    If the slave state was changed,



src/master/master.cpp
Lines 6884 (patched)
<https://reviews.apache.org/r/64011/#comment269920>

    back ticks around `slave->info` and `slaveInfo`



src/master/master.cpp
Lines 6885 (patched)
<https://reviews.apache.org/r/64011/#comment269921>

    s/the slave/`slave`/


- Vinod Kone


On Nov. 28, 2017, 12:28 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64011/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2017, 12:28 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When an agent reregisters, the master will now always update
> the agent information it holds in memory, and will write any
> changes back to the registry if necessary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3 
>   src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f 
>   src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b 
> 
> 
> Diff: https://reviews.apache.org/r/64011/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message