mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 61473: Do not kill non partition aware tasks.
Date Tue, 28 Nov 2017 00:25:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61473/#review191674
-----------------------------------------------------------



The approach looks good to me.


src/master/http.cpp
Line 320 (original), 320 (patched)
<https://reviews.apache.org/r/61473/#comment269882>

    Style: should be `JSON::ArrayWriter* writer`.



src/master/http.cpp
Lines 322 (patched)
<https://reviews.apache.org/r/61473/#comment269883>

    Style: `&` should be attached to the type.



src/master/http.cpp
Lines 343-345 (patched)
<https://reviews.apache.org/r/61473/#comment269885>

    I may be ignorant of the discussion behind this, but since we don't treat these tasks
as completed anymore, do we really need to maintain backwards compatibility here, in stats
and metrics? This kind of hides the real state of things.



src/master/master.cpp
Line 9370 (original), 9322 (patched)
<https://reviews.apache.org/r/61473/#comment269878>

    I would suggest moving this closer to `newTaskState` selection logic for readability.



src/master/master.cpp
Line 10318 (original), 10271-10272 (patched)
<https://reviews.apache.org/r/61473/#comment269912>

    Is there any reason not to iterate like this?
    ```cpp
    foreachvalue (const Owned<Task>& task, framework->unreachableTasks) {
      // ...
    }
    ```


- Ilya Pronin


On Nov. 27, 2017, 2:08 p.m., Megha Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61473/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2017, 2:08 p.m.)
> 
> 
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7215
>     https://issues.apache.org/jira/browse/MESOS-7215
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Master will not kill the tasks for non-Partition aware frameworks
> when an unreachable agent re-registers with the master.
> Master used to send a ShutdownFrameworkMessages to the agent
> to kill the tasks from non partition aware frameworks including
> the ones that are still registered which was problematic because
> the offer from this agent could still go to the same framework which
> could then launch new tasks. The agent would then receive tasks
> of the same framework and ignore them because it thinks the
> framework is shutting down. The framework is not shutting down of
> course, so from the master and the scheduler's perspective the task
> is pending in STAGING forever until the next agent reregistration,
> which could happen much later. This commit fixes the problem by
> not shutting down the non-partition aware frameworks on such an
> agent.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 
>   include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e 
>   src/master/http.cpp 10084125deb839a9846a4f64d2e433ff02754c02 
>   src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3 
>   src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f 
>   src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7 
> 
> 
> Diff: https://reviews.apache.org/r/61473/diff/20/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message