mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.
Date Tue, 28 Nov 2017 00:25:12 GMT


> On Nov. 21, 2017, 10:04 a.m., Alexander Rukletsov wrote:
> > src/internal/devolve.cpp
> > Lines 194-196 (original), 194-196 (patched)
> > <https://reviews.apache.org/r/63741/diff/1/?file=1892879#file1892879line194>
> >
> >     What about `evolve()`?
> 
> Jiang Yan Xu wrote:
>     I suppose I need to handle it there too since `v1::scheduler::Call evolve(const scheduler::Call&
call)` is defined there but I have no idea where this is ever used/useful?

I added the custom converstion to `v1::scheduler::Call evolve(const scheduler::Call& call)`
with a TODO.


> On Nov. 21, 2017, 10:04 a.m., Alexander Rukletsov wrote:
> > src/internal/devolve.cpp
> > Lines 199-200 (patched)
> > <https://reviews.apache.org/r/63741/diff/1/?file=1892879#file1892879line199>
> >
> >     Maybe a simple `if(){}` for now? Maybe the next special case will not be type
dependent?

SGTM.


> On Nov. 21, 2017, 10:04 a.m., Alexander Rukletsov wrote:
> > src/internal/devolve.cpp
> > Lines 203-204 (patched)
> > <https://reviews.apache.org/r/63741/diff/1/?file=1892879#file1892879line203>
> >
> >     I believe we prefer writing `CopyFrom()` explicitly, no?

I don't think it's estalished as a rule even though we do use CopyFrom most often previously.
Now that we have upgraded to protobuf 3.5 with move semantics, I think we can probably standarize
on prefering the assignment operator as the choice between copy and move can be determined
simply by the rvalue-ness of the operand unless copying is explicitly intended. I understand
that this particular case wouldn't be moved but styling wise it's more futre-proof. We should
further this discussion. For now I think this is OK as this style is already used in the codebase.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63741/#review191605
-----------------------------------------------------------


On Nov. 15, 2017, 10:41 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63741/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2017, 10:41 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8200
>     https://issues.apache.org/jira/browse/MESOS-8200
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also improved logging to show the suppressed roles.
> 
> 
> Diffs
> -----
> 
>   src/internal/devolve.cpp 3a02490d734ef4a558b448871f9a1054d832f457 
>   src/master/master.cpp 81192d5ce7c095495a5faa534d4792601e540e0e 
> 
> 
> Diff: https://reviews.apache.org/r/63741/diff/1/
> 
> 
> Testing
> -------
> 
> Tested together with /r/63830/.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message