mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 64010: Added an optional SlaveInfo parameter to Allocator::updateSlave().
Date Mon, 27 Nov 2017 23:29:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64010/
-----------------------------------------------------------

(Updated Nov. 27, 2017, 11:29 p.m.)


Review request for mesos and Vinod Kone.


Summary (updated)
-----------------

Added an optional SlaveInfo parameter to Allocator::updateSlave().


Repository: mesos


Description (updated)
-------

This allows callers to inform the allocator that an existing agents
SlaveInfo changed, probably because it was restarted and reregistered
with the same id.

Additionally, this also provides callers with an option to reset
existing offer filters for a given slave id when the update is
applied.

While the existing HierarchicalDRFAllocator only cares about the domain
and hostname fields, we still have to pass the full SlaveInfo here
because custom allocators might base their decisions on other fields,
for example attributes.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp ae122003487ca8956573e993cd3993aa8cc286f1 
  src/master/allocator/mesos/allocator.hpp 8fa4fdeec4ec64bcd49fc442c230d8684a11cfd9 
  src/master/allocator/mesos/hierarchical.hpp 2c4832b29842330fa57756cd3d4202f265a820f3 
  src/master/allocator/mesos/hierarchical.cpp cfeeb3bfa3ad7d78ff6e22cfc4adb1f0efa05629 
  src/tests/allocator.hpp 6a84f1beb86dceb5a5e9bf4615c13a216f3d0905 
  src/tests/hierarchical_allocator_tests.cpp f0f95ba4f667bf8ea54e985d8cde913a4170d8ff 


Diff: https://reviews.apache.org/r/64010/diff/3/

Changes: https://reviews.apache.org/r/64010/diff/2-3/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message