mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Date Mon, 27 Nov 2017 17:45:57 GMT


> On Nov. 16, 2017, 7:25 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 121-124 (patched)
> > <https://reviews.apache.org/r/63862/diff/1/?file=1893974#file1893974line121>
> >
> >     Would it be possible to instead change the default network setting to `bridge`?
We may have talked about this, I don't remember. What should the default be if `host` doesn't
work on Windows?
> 
> Akash Gupta wrote:
>     I'm not sure. The default is set in the protobuf, so I'm not sure how the default
can be changed for Linux vs Windows. I guess we can have `host` AND `bridge` = `nat`, but
that seems hacky.

Resolved by having bridge and host = nat.


> On Nov. 16, 2017, 7:25 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 399-401 (patched)
> > <https://reviews.apache.org/r/63862/diff/1/?file=1893974#file1893974line399>
> >
> >     Would this read better with an `all_of`?
> 
> Akash Gupta wrote:
>     Yeah I can remove the loops with `std::algorithm`

eh, I think keeping the loop reads the best in this case.


> On Nov. 16, 2017, 7:25 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 578-624 (original), 703-752 (patched)
> > <https://reviews.apache.org/r/63862/diff/1/?file=1893974#file1893974line703>
> >
> >     Wait, why did we remove it from the list of skipped tests?
> 
> Akash Gupta wrote:
>     I #ifdef'd out the tests that won't work due to limitations in Windows at the OS
level based off this JIRA issue https://issues.apache.org/jira/browse/MESOS-6392 . Should
they still be TEST_F_TEMP_DISABLED_ON_WINDOWS?

after discussing, we agreed to change to TEST_F_TEMP_DISABLED_ON_WINDOWS.


> On Nov. 16, 2017, 7:25 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 790-919 (original), 926-1058 (patched)
> > <https://reviews.apache.org/r/63862/diff/1/?file=1893974#file1893974line926>
> >
> >     Why are these being compiled out?
> 
> Akash Gupta wrote:
>     I #ifdef'd out the tests that won't work due to limitations in Windows at the OS
level based off this JIRA issue https://issues.apache.org/jira/browse/MESOS-6392 . Should
they still be TEST_F_TEMP_DISABLED_ON_WINDOWS?

after discussing, we agreed to change to TEST_F_TEMP_DISABLED_ON_WINDOWS


- Akash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review191223
-----------------------------------------------------------


On Nov. 27, 2017, 5:45 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2017, 5:45 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
> 
> 
> Bugs: MESOS-7342
>     https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
>   - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
>     sandbox).
>   - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
>   - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_tests.cpp 5cabf5a0b0164f9923008677c58806c8931cbc8d 
> 
> 
> Diff: https://reviews.apache.org/r/63862/diff/2/
> 
> 
> Testing
> -------
> 
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [  PASSED  ] 754 tests.
> 
> 
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [  PASSED  ] 11 tests.
> 
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [  PASSED  ] 12 tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message