mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <>
Subject Re: Review Request 63860: Windows: Mapped the Docker network info types.
Date Mon, 27 Nov 2017 17:37:39 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 27, 2017, 5:37 p.m.)

Review request for mesos, Andrew Schwartzmeyer and John Kordich.


Rebased and changed host mode to nat mode on Windows.

Bugs: MESOS-7342

Repository: mesos

Description (updated)

The current Network enum in DockerInfo is specific to Linux containers.
Instead of supporting {host, bridge, none, user} networks, Windows
docker supports {nat, none, user} networks. Now, if the host or bridge
network type is sent to the Windows agent, it will be internally
converted to nat.

Diffs (updated)

  src/docker/docker.cpp 722a54ad113fc4e2bb22a8f08e307ab38d5fbfed 




See for test results.


Akash Gupta

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message