mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 63999: Added env var to set default flags for parallel test runner.
Date Mon, 27 Nov 2017 15:45:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63999/#review191898
-----------------------------------------------------------


Ship it!




Ship It!

- Armand Grillet


On nov. 27, 2017, 3:44 après-midi, Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63999/
> -----------------------------------------------------------
> 
> (Updated nov. 27, 2017, 3:44 après-midi)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch modifies the parallel test runner to examine the
> environment variable 'MESOS_GTEST_RUNNER_FLAGS' for a default set of
> flags to pass. Flags given explicitly on the command line always have
> precedence over default flags from the environment variable.
> 
> This allows e.g., to set the default level of parallelism to not
> overload systems with many CPUs during 'make check' (which could
> ultimately lead to tests hitting timeouts).
> 
> 
> Diffs
> -----
> 
>   support/mesos-gtest-runner.py 408e661f4fc9d0060c0eb7a45f1dfd1396f4f6c6 
> 
> 
> Diff: https://reviews.apache.org/r/63999/diff/2/
> 
> 
> Testing
> -------
> 
> Verified manually that
> 
>     $ MESOS_GTEST_RUNNER_FLAGS=-j20 ../support/mesos-gtest-runner.py ./3rdparty/stout/tests/stout-tests
> 
> executes 20 concurrent runs and that
> 
>     $ MESOS_GTEST_RUNNER_FLAGS=-j20 ../support/mesos-gtest-runner.py -j6 ./3rdparty/stout/tests/stout-tests
>     
> executes 6 concurrent runs and that
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message