mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64086: Removed currently unneeded 'AWAIT_READY's in 'MockResourceProvider'.
Date Mon, 27 Nov 2017 15:18:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64086/
-----------------------------------------------------------

(Updated Nov. 27, 2017, 4:18 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Repository: mesos


Description (updated)
-------

The 'AWAIT_READY's in 'MockResourceProvider' let to the resource
provider not being usable with paused clock as we would run into a
deadlock in that case.

This patch removes the explicit awaits here to make the resource
provider usable. We should consider making it easier to debug send
failures in the resource provider, e.g., by surfacing the future
responses to users in some way, or by added additional logging.


Diffs
-----

  src/tests/mesos.hpp e5c2b697a4401f010a7d77ae9acb8a9cbd3846bc 


Diff: https://reviews.apache.org/r/64086/diff/1/


Testing
-------

`make check`, tests as part of https://reviews.apache.org/r/63843/.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message