mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.
Date Mon, 27 Nov 2017 14:43:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63795/
-----------------------------------------------------------

(Updated Nov. 27, 2017, 10:43 p.m.)


Review request for mesos, Alexander Rukletsov and Avinash sridharan.


Changes
-------

Addessed the issue on macOS that the `connect()` function will return the error `Invalid argument`.
The root cause of this issue is, on macOS setting the 3rd paramter (`addrlen`) of the `connect()`
function to the size of `sockaddr_storage` is not correct, instead we should set it to `sockaddr_in`
(IPv4) or `sockaddr_in6` (IPv6).


Bugs: MESOS-8050
    https://issues.apache.org/jira/browse/MESOS-8050


Repository: mesos


Description
-------

Made `mesos-tcp-connect` support IPv6.


Diffs (updated)
-----

  src/checks/tcp_connect.cpp 2514f4aebcc634b18cd2b3c36529222fe456e903 


Diff: https://reviews.apache.org/r/63795/diff/6/

Changes: https://reviews.apache.org/r/63795/diff/5-6/


Testing
-------


Thanks,

Qian Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message