mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64084: Made explicit that a 'switch' covers all branches.
Date Mon, 27 Nov 2017 14:07:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64084/
-----------------------------------------------------------

(Updated Nov. 27, 2017, 2:07 p.m.)


Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description (updated)
-------

Some compilers fail to recognize that the list of cases in this
'switch' statement is exhaustive. Add an explicit 'UNREACHABLE()' to
hint to the compiler that we expect to have handled all possible cases.


Diffs
-----

  src/common/protobuf_utils.cpp c1bd8b0b7b517cc5001dd914f6291598ec1da73b 


Diff: https://reviews.apache.org/r/64084/diff/1/


Testing
-------

`make check` (clang, macos).


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message