mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64001: Made sure all true allocator agent updates trigger allocations.
Date Mon, 27 Nov 2017 10:51:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64001/
-----------------------------------------------------------

(Updated Nov. 27, 2017, 11:51 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Fixed commit message.


Summary (updated)
-----------------

Made sure all true allocator agent updates trigger allocations.


Repository: mesos


Description (updated)
-------

The allocator method 'updateSlave' can be used to modify either an
agent's capabilities, its total resources, or both. It is expected
that this method triggers an allocation whenever a change occurred.

This patch fixes an issue where if the method as implemented in the
hierarchical allocator was called with new capabilities but the current
total resources, not allocation would have been triggered, even though
the capabilities were updated.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp cfeeb3bfa3ad7d78ff6e22cfc4adb1f0efa05629 


Diff: https://reviews.apache.org/r/64001/diff/2/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message